Better Menus (CoreRPG, 5E/etc)

[rocketvaultgames]

So, I did a lot of testing on this pre-4.5 release and was not able to find a solution. I believe it had something to do with the event I was looking at for module load changes but those changes were not acted on until the menu was selected so shouldn't have caused any issue like this. Even disabling the books section didnt resolve it which was where the code ran to check for it.

That said, I've not seen the issue in 4.5 so something updated in FG 4.5 that resolved it.

I released an updated version today that will resolve the Menu name changes introduced in 4.5.



The only menu that should not be static is the books menu. Unfortunately there is no way to programatically change the size of a Panel which is what the system uses. Once it reaches a specific size it adds the scroll bar.

Sorry, I didn't see this until now... I really appreciate you having looked into all of this and responding.

I'm still seeing the regular lag spike in 4.5.1. Toggling between Sidebar and Menus fixes it just like before.

[celestian]

Sorry, I didn't see this until now... I really appreciate you having looked into all of this and responding.

I'm still seeing the regular lag spike in 4.5.1. Toggling between Sidebar and Menus fixes it just like before.

I ran my checks in the TEST channel before 4.5 was released and was not able to see lag spikes when I had about 10 modules loaded. In anycase I dont run persistent pulsing checks for anything in my code. There are some events I monitor and if those are causing it thats API side I can't resolve. I updated the event specific to this to use the same one that JPG used for the new "Books" of theirs for 4.5.

[metaldm007]

Hey there, just curious if there's any compatibility between this extension and extensions that add new menu options, such as Timer. As it stands, the timer button does show up with the default menu but not with Better Menus. Figured I'd ask because I couldn't find anyone else experiencing this in the thread.

[celestian]

Hey there, just curious if there's any compatibility between this extension and extensions that add new menu options, such as Timer. As it stands, the timer button does show up with the default menu but not with Better Menus. Figured I'd ask because I couldn't find anyone else experiencing this in the thread.

There is functionality that developers can use to add their own menus. The first post links to it which is here : https://www.fantasygrounds.com/forum...l=1#post574918

[metaldm007]

There is functionality that developers can use to add their own menus. The first post links to it which is here : https://www.fantasygrounds.com/forum...l=1#post574918

Thanks for the clarification.

[rocketvaultgames]

I ran my checks in the TEST channel before 4.5 was released and was not able to see lag spikes when I had about 10 modules loaded. In anycase I dont run persistent pulsing checks for anything in my code. There are some events I monitor and if those are causing it thats API side I can't resolve. I updated the event specific to this to use the same one that JPG used for the new "Books" of theirs for 4.5.

I'm still getting these lag spikes with 0 modules loaded and no other extensions except for Better Menus in my main campaign.

I don't get these lag spikes in a new campaign (0 Mods/other extensions)...

What else about a campaign could be possibly causing these spikes?

[celestian]

I'm still getting these lag spikes with 0 modules loaded and no other extensions except for Better Menus in my main campaign.

I don't get these lag spikes in a new campaign (0 Mods/other extensions)...

What else about a campaign could be possibly causing these spikes?

I'm not suggesting the issue is not Better Menus but there is nothing I've tried that will resolve it. I can only speculate as to the cause and most of what I come up with is outside of my ability to correct.

[rocketvaultgames]

I'm not suggesting the issue is not Better Menus but there is nothing I've tried that will resolve it. I can only speculate as to the cause and most of what I come up with is outside of my ability to correct.

Do you have any guesses as to what it might be? Size of Log File? Total size of Campaign Folder? Anything like that? Leftover data from a previously used but disabled extension?

Until the default menu bar becomes movable, I'm sticking with Better Menus even with the lag spikes, but I'm willing to try to solve the issue on my end. I'm just not even sure where to start.

[celestian]

Do you have any guesses as to what it might be? Size of Log File? Total size of Campaign Folder? Anything like that? Leftover data from a previously used but disabled extension?

Until the default menu bar becomes movable, I'm sticking with Better Menus even with the lag spikes, but I'm willing to try to solve the issue on my end. I'm just not even sure where to start.

I am not sure if its any of those issues but my test environment would not have large files for either of those. I tested dropping various pieces connected to the modules. In that case I thought it was because I was looking for changes but even with that disabled it didnt change things. It's probably some interaction with the API but to the best of my knowledge I have no "watch for these changes all the time" which would cause it to "check" while you might be moving or anything else. My checks only trigger when a menu option is clicked.

[rocketvaultgames]

Not a huge deal, but it looks like if Better Menus is loaded, but toggled off so that the default sidebar is used, Better Menus prevents FG from remembering the expansion state of the sidebar (small/med/large) upon reloading.